Keep in mind that from the perspective of most Rosharans, Elhokar isn’t particularly classist. Sure, he’s a lighteyes and views darkeyes in an inferior light, but he doesn’t specifically mistreat them; not onscreen, anyway. Yes, if it hadn’t been for Dalinar, he might have killed Kaladin because of what he said about Amaram, and that’s definitely extreme. But have you ever done something in a fit of anger? Kaladin had just completely ruined the plans that they’d made. That was not the time to get revenge on Amaram, and he should have known it, but he acted on strong emotions - and so did Elhokar, afterward. Besides, it was the law.
Elhokar has been drunk like twice onscreen iirc. Both of those times were at the end of WOR, close together. I don’t think that counts as a personality trait. And while he’s quite inept at some things, he isn’t at others. Everyone is inept at something.
I pretty much agree with your view of Moash. In fact, I think he can still have a redemption arc. But killing Elhokar was wrong. It made sense for Moash and I don’t blame him for it, but he still shouldn’t have done it. That’s why I disputed your “he did nothing wrong”.
It’s hard for me to see Elhokar Kholin swearing the First Ideal as well, but I recognize that it was foreshadowed. Brandon painted Elhokar as someone who had made a lot of mistakes, and someone who was certainly broken. He also consistently tried to improve himself, even if he wasn’t doing the best at it that he could have. So I understand his path toward Radiancy, even if I probably wouldn’t have guessed that he would actually get there. (Which, in the end, he didn’t.)