I agree with this. I personally find the scene hilarious (probably because it plays directly into the kind of humor I enjoy), but even without how funny it is, it gives us a good look at Shallans character at the moment.
Is she acting like a spoiled child? Maybe, but I wouldn't say that's a bad thing, or untrue to her character. She's a noble men's daughter and has been treated such her whole life. She just came from living with the princess as well. This is Shallan's first experience with the real, harsh world of people who don't care about her rank and want to take advantage of her. So if she does seem a little bit genuinely spoiled I think that's because she is, and she's just learning what the world is like.
I also think it's important to note how she's taking one of her first go's at acting, or impersonating. This later because a massive facet of her character with the creation of Veil and Radiant. She's acting like a worse person than she is, because that's what [ghostblood lady she ran into who's name I forgot] was trying to teach her. Shallan's own spoiled-ness leeks through, yes, but most of it is acting.
To me, the scene makes her seem less like a spoiled brat, and more like a scared child. She's completely out of her depth, so she falls into the cliche of a spoiled lighteyes because it's safe, and works (for the most part). Kaladin isn't aware of her struggles the way the reader is, so he sees her as that facade she's put up. But we as the reader know she's barely staying together on the inside. The scene allows us to see this through the contrast of who she's pretending to be, who people see her as, and what she really is deep down.
I definitely think he could benefit from a romantic relationship, but I think he needs to go slow. I think it would be really great if he ended up with someone he considers a really close friend first, before they both consider romance. It would give him time to open up to the person and become comfortable around them before they get into the added tension of romance. It would give time for Kaladin to heal a little more, and his partner would also be able to aid him in that healing as well.
I'm not saying he shouldn't be in a relationship right now, I'm just saying it would be best for him if he took things slowly, and dated someone he already trusted.
Perhaps that's why it didn't work out with [Lin? that one girl? I can't remember names this morning]. They both jumped into the relationship, wanting it to be romantic. There was no time for the extra building of trust that I think Kaladin needs right now, and [Lin-girl-person] ended up misunderstanding him and not being able to really get to know him because she hadn't taken the time to break down his walls.
Or they just weren't made for each other and I'm rambling, but I hope you can kinda see what I mean.